search

rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
146 stars 23 forks source link

Not Activated / Multiple Wins Checker: fix bug that blocks request because of SGTools permission being removed #1637

Closed at46 closed 3 years ago

at46 commented 4 years ago

Description Not Activated/Multiple Win Checker doesn't work with 8.8.1. It just loads forever.

Steps to Reproduce

  1. Activate Not Activated/Multiple Win Checker
  2. Go to any user profile e.g. https://www.steamgifts.com/user/revilheart
  3. click on the ? and then on check
  4. checker will load forever

Expected Behavior Retrieve and display the info from sgtools.info.

Console Errors

Error: WebExtension context not found! ExtensionParent.jsm:1239:13
Creating CSS for url: https://www.steamgifts.com/user/revilheart index.js:2760:29
Unchecked lastError value: Error: Could not establish connection. Receiving end does not exist. webrequest.js:107
Laden fehlgeschlagen für das <script> mit der Quelle "https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js". revilheart:26:1
Unchecked lastError value: Error: Could not establish connection. Receiving end does not exist. webrequest.js:107
Assuming dark theme and adjusting colors Steamgifts Secret Sniffer.user.js:831:15
MouseEvent.mozPressure sollte nicht mehr verwendet werden. Verwenden Sie PointerEvent.pressure stattdessen. esgst.js:42:91538
TypeError: e is undefined 2 esgst.js:88:665274
Quellübergreifende (Cross-Origin) Anfrage blockiert: Die Gleiche-Quelle-Regel verbietet das Lesen der externen Ressource auf https://www.sgtools.info/nonactivated/revilheart. (Grund: CORS-Kopfzeile 'Access-Control-Allow-Origin' fehlt).

Quellübergreifende (Cross-Origin) Anfrage blockiert: Die Gleiche-Quelle-Regel verbietet das Lesen der externen Ressource auf https://www.sgtools.info/nonactivated/revilheart. (Grund: CORS-Anschlag schlug fehl).

Screenshots Bildschirmfoto_2020-09-04_18-17-31

System (please complete the following information):

Additional Context For me it seems Firefox is blocking the requests to sgtools but there was neither a FF update nor for any other add-on I'm using nor did I change any other setting. It worked fine with 8.7.4 so I guess you changed something about how the checker works?

rafaelgomesxyz commented 4 years ago

It worked for me, so it must be the same incompatibility issue with old Firefox as #1635. I'll see if I can look into it in the weekend.

at46 commented 4 years ago

With Firefox 80.0.1 (64-Bit) it indeed works fine.

rafaelgomesxyz commented 3 years ago

Sorry for the late response. Are you positive that with Firefox 80 it worked fine using your exact same settings? I ask because there was a bug that was preventing requests to SGTools, because the SGTools permission was removed when the themes were removed. So it would be odd for it to work on a newer Firefox if it was still missing the permission. But regardless, it should be fixed in the next version.

at46 commented 3 years ago

I used an older Firefox profile with ESGST I normally don't use any more. All I did was updating ESGST and testing the "Not Activated / Multiple Wins Checker" so probably not the same settings. Thanks for fixing this. If I find some time tomorrow I will test the beta.

at46 commented 3 years ago

Updated to 8.8.2 and "Not Activated / Multiple Wins Checker" is working fine again. Thanks Rafael.