search

rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
147 stars 23 forks source link

Show progress while syncing hidden games #1658

Open at46 opened 4 years ago

at46 commented 4 years ago

Is your enhancement request related to a problem? Please describe. Syncing hidden games can take quite some time if you have a few thousand games hidden (I've 4k but some have much more: https://www.steamgifts.com/discussion/or2zV/). To make it more clear that the sync is working it would be nice to see the progress.

Describe the solution you'd like. E.g. showing something like "page xxx/yyy synced" or "zz% done" or similar to how you've done it for won games.

Describe alternatives you've considered. It's now possible to see the progress in the new "SteamGifts Request Log" however I would prefer if it is shown directly.

rafaelgomesxyz commented 4 years ago

Will add it, but are you aware of https://www.steamgifts.com/account/settings/profile?esgst=settings&id=updateHiddenGames? With this option enabled, whenever you add/remove a game from the hidden list, it automatically updates the data, so you don't have to keep syncing those 4K games every time.

at46 commented 4 years ago

Thanks, I'm already using https://www.steamgifts.com/account/settings/profile?esgst=settings&id=updateHiddenGames which is great especially now that sg has the rate limits but once a month I like to make a complete sync.

at46 commented 4 years ago

IMHO you should also add a warning in the syncing options that syncing hidden games can make a huge number of requests if you have a lot of hidden games.

Eiion commented 4 years ago

Will add it, but are you aware of https://www.steamgifts.com/account/settings/profile?

I wasn't aware. Activated that and also the same feature for new blacklist entries. Are there other known features that would result in large numbers of requests which could be avoided by using other features I'm not aware of? I'm asking because such automatic features (that partially sync on the side) reduce the risk of running into the limits. So a user can go for longer at "full speed" (once user adjustable request limitation is added) before limits are hit. (Again, just so user experience is more fluent without waiting a second for each single GA while looking at only a few pages anyways and thus not likely to run into issues.)

I'm not using any of the two much but I'd suggest to make this the standard way to handle things and remove the features from the sync. (Or instead of removing add a confirm checkmark for users to acknowledge that activating this feature will have an effect on their remaining requests to the page, similar to what at46 suggested above).