rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
146 stars 23 forks source link

SteamGifts Request Log: add more viewing options #1672

Closed Eiion closed 3 years ago

Eiion commented 3 years ago

Is your enhancement request related to a problem? Please describe. Instead of having a part for "This Minute", "This Hour" and "This Day" - and adding data from "This Minute" to "This Hour" as soon as the next minute starts (which is wrong in itself as "This Minute" should already be part of "This Hour") and from "This Hour" to "This Day" (I didn't check but I assume the same mistake is done as before with adding data only after it happened instead of already including it) - give us a time frame selector.

Describe the solution you'd like. Give us a time frame selector.

( ) Minutes ( ) Hours ( ) Day (or "Days", though I don't see a need to log data for longer than a day) And people choose the one they want to see. So when selecting Minutes, data moves from "This Minute" to "1 Minute ago", "2 Minutes ago" and so on. Same for the "Hours" selection.

Additional Context Currently data basically gets "lost" after moving from "This Minute" to "This Hour" as the list could get extremely long for some people which poses an issue when wanting to see what happened e.g. 2 or 3 minutes ago.

I don't know if something like that is needed, it just came to my mind when I just checked again what actually happens on the Won page realizing that I can't really identify what happened a Minute ago when loading pages with endless scrolling takes many minutes to check if the Previously Wishlisted filter.

Eiion commented 3 years ago

I'd furthermore would like to suggest to add request log stats (only interesting for the next few months I assume) to get condensed stats (without all the links) for the numbers of request without all the scrolling. Maybe added on the top right or left or as a header line of the request log pop up (which I'd like the best). Could be something like this: this minute x/120 - last minute x/120 - this hour x/2400 - last hour x/2400 - this day x/14400 - last day x/14400

or like this: this minute x/120 last minute x/120 this hour x/2400 last hour x/2400 this day x/14400 last day x/14400

rafaelgomesxyz commented 3 years ago

and adding data from "This Minute" to "This Hour" as soon as the next minute starts (which is wrong in itself as "This Minute" should already be part of "This Hour")

I don't understand what you mean by this. "This Minute" data should already be included in "This Hour", and same for "This Day".

I'd furthermore would like to suggest to add request log stats (only interesting for the next few months I assume) to get condensed stats (without all the links)

I think #1664 already covers this, because you can just collapse all sections and get those quick stats.

I added the option to separate by minutes/hours/days.

Eiion commented 3 years ago

I think back when I wrote this I checked and "This Minute" data wasn't inlcuded in "This Hour". I cannot remember anymore. I'm also not having the time now to check again. If that's already what is actually happening and I was wrong, then forget about that part.

1664 somewhat covers it by giving similar results when collapsing all. But it doesn't give the quick overview when not collapsed - you first had to collapse everything. If you work the non-collapsed categories to have an eye on the data then I see an additional stat overview as useful.