search

rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
147 stars 23 forks source link

[bug] Extension stopped working #1676

Closed Eiion closed 3 years ago

Eiion commented 4 years ago

Description After doing a re-boot of the system with the browser still open on Group or Wishlist ESGST doesn't work anymore. I assume that this is related to https://www.steamgifts.com/account/settings/profile?esgst=settings&id=useTemporaryStorage which I had activated earlier today.

Steps to Reproduce

  1. Activate useTemporaryStorage
  2. open Browser with tab on Group or Wishlist
  3. restart System without closing the Browser or the SG tab first.
  4. See error

Expected Behavior Start Browser, open SG, see ESGST working

Console Errors

Checking backup...
esgst.js:1 1605660147938 NaN
search?type=wishlist:161 USP is not accessible
checkIfUspIsReady @ search?type=wishlist:161
3esgst.js:88 Uncaught (in promise) TypeError: Cannot read property 'setAttribute' of undefined
    at Ro.cfh_saveReply (esgst.js:88)
    at Ro.cfh_setReply (esgst.js:88)
    at Object.setPopout (esgst.js:88)
    at Ro.init (esgst.js:88)
    at async R.loadFeatures (esgst.js:1)
    at async t (esgst.js:88)
secure.quantserve.com/quant.js:1 Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
quantcast.mgr.consensu.org/tcfv2/cmp2.js:1 Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
p-JTKTckadxK45t.gif:1 Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
www.google-analytics.com/analytics.js:1 Failed to load resource: net::ERR_BLOCKED_BY_CLIENT
search?type=wishlist:161 USP is not accessible
checkIfUspIsReady @ search?type=wishlist:161
DevTools failed to load SourceMap: Could not load content for chrome-extension://ibedmjbicclcdfmghnkfldnplocgihna/lib/browser-polyfill.min.js.map: HTTP error: status code 404, net::ERR_UNKNOWN_URL_SCHEME

System (please complete the following information):

Additional Context Restarting the Browser with SG already open as a starting page showed ESGST but as soon as the page was changed to e.g. Wishlist ESGST was gone. Several browser re-starts with SG open initially or opened afterwards manually didn't help. Switching the extension on and off didn't help either. Deactivating useTemporaryStorage (after ESGST was open when re-starting the browser with SG as one of the starting pages) had no effect on ESGST working as soon as changing pages within SG. Opening SG in a new page doesn't make ESGST work. Restoring the last Backup didn't make ESGST work again.

EDIT: Only uninstalling the extension, re-installing it and restoring the old backup from little over a day ago (before activating some of the features of Others) made ESGST working again.

Eiion commented 4 years ago

I've played around with several filters to see if everything is working again bit it appears that the trading card filter is broken. Or rather caching that data for the games is? Either or...

Here's the current list of errors:

Checking backup...
esgst.js:1 1605662951989 NaN
3esgst.js:88 Uncaught (in promise) TypeError: Cannot read property 'setAttribute' of undefined
    at Ro.cfh_saveReply (esgst.js:88)
    at Ro.cfh_setReply (esgst.js:88)
    at Object.setPopout (esgst.js:88)
    at Ro.init (esgst.js:88)
    at async R.loadFeatures (esgst.js:1)
    at async t (esgst.js:88)
2search?type=group:161 USP is not accessible
checkIfUspIsReady @ search?type=group:161
DevTools failed to load SourceMap: Could not load content for chrome-extension://ibedmjbicclcdfmghnkfldnplocgihna/lib/browser-polyfill.min.js.map: HTTP error: status code 404, net::ERR_UNKNOWN_URL_SCHEME

EDIT: I've tried fixing it by de-activating the trading cards related options in the settings (in Giveaways and Games) but that didn't help.

Eiion commented 4 years ago

In order to get the trading card filter back working again I've tried the Delete feature (for the first time) and deleted Games - All. I assumed that after deleting that data ESGST would then try to load everything again (which probably would make things take even longer) - but nothing changed. The green Trading Card tag still doesn't show up for games where Steam Web Integration shows that they should have it.

EDIT: I repeated it once again, re-started the browser after deleting and deactivating the trading cards related settings. After re-activating the settings I got a request to give permissions. Turns out all previously given permissions where gone - probably due to uninstalling ESGST and re-installing it due to getting it working again. Now all game information is shown again.

I'd like to suggest that if after newly installing ESGST (or restoring a backup) a pop-up shows up automatically asking to give all the needed permisions which (after clicking OK) opens the permission tab.

rafaelgomesxyz commented 3 years ago

The temporary storage will be removed in the next version, I have another solution that shouldn't cause problems.

As for any other issues reported here, I suggest creating a separate issue if they're still a problem, to keep things clear.