search

rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
147 stars 23 forks source link

Fix bug that prevents features from opening in a new tab #1677

Closed Eiion closed 3 years ago

Eiion commented 4 years ago

Description Clicking the giveaway extractor button does nothing.

Steps to Reproduce

  1. Go to any train discussion page or first wagon
  2. Click on giveaway extractor button
  3. See that nothing happens.

Console Errors none

Additional Context No idea when it stopped working - last time I've used it is several months ago so I don't know with which version the button has stopped working.

Eiion commented 3 years ago

Does this fix include the library/wishlist checker opening in a new tab?

rafaelgomesxyz commented 3 years ago

What's wrong with the library/wishlist checker?

Eiion commented 3 years ago

You've renamed the issue to "Fix bug that prevents features from opening in a new tab" - and as it seems the issue not only existed for the giveaway extractor but also the library/wishlist checker and the bookmarked giveaways. All of them are supposed to open in a new tab and non of them are working. I forgot to report but the new title of the issue suggests that all such issues could be fixed with it. Hence me asking if that's the case.

rafaelgomesxyz commented 3 years ago

Giveaway Bookmarks is indeed another affected feature, but the library/wishlist checker doesn't use a button to open in a new tab, it uses a simple link with target=_blank, so it shouldn't be affected by the bug, hence why I'm confused. Are you sure the library/wishlist checker isn't opening in a new tab?

Eiion commented 3 years ago

I've just given it another try and it worked. A few days or one-two weeks back when I needed the feature it didn't. Hence I was assuming it was broken as well.