search

rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
147 stars 23 forks source link

Pale Moon / Userscript: fix bug that prevents settings from being saved #1717

Closed Gortus closed 3 years ago

Gortus commented 3 years ago

Description In version 8.8.8, the Save Changes button in Settings doesn't do anything. There is no "settings changed" confirmation dialog, and any changes made aren't saved.

Steps to Reproduce

  1. Go to "www.steamgifts.com"
  2. Click on "ESGST button" to open the settings dialog
  3. Make any change
  4. Click Save Changes

Expected Behavior A confirmation dialog should display, and any changed settings should be reflected on repeating the steps.

Console Errors userscript.html?name=Enhanced%20SteamGifts%20%26%20SteamTrades%20(ESGST).user.js&id=0a8c8624-8242-4f09-9735-b06545e6c3cc:15033 [ESGST] browser is not defined

System (please complete the following information):

Additional Context Some comments on the SteamGifts forum thread say that switching to Extension version fixes the problem. Reverting Userscript to 8.8.7 fixes it for me.

ALuserX commented 3 years ago

Same behaviour in Palemoon 29.1.1 I use ESGST as a browser extension.

palemoon:[ESGST] browser is not defined sandbox.js:340

rafaelgomesxyz commented 3 years ago

Fix should be coming in the next version, set to be released on Monday. Sorry it took so long.

Gortus commented 3 years ago

Confirmed fixed for me, thanks!