search

rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
147 stars 23 forks source link

Giveaway Filters: remove restrictions from Minutes To End and Minutes From Start #1718

Closed cprn closed 3 years ago

cprn commented 3 years ago

Is your enhancement request related to a problem? Please describe. I'm trying to sort only those of the Entered giveaways that haven't finished yet to decide which to leave to redistribute points. Unfortunately finished giveaways are also sorted.

Describe the solution you'd like. Setting up the Minutes To End filter to 1-null should only show giveaways that have at least one minute left, i.e. hide the finished giveaways. Currently it doesn't filter anything unless both values are entered and even if I set it to 1-1 (only one minute left) it still shows finished giveaways.

Describe alternatives you've considered. A boolean filter to show only unfinished giveaways.

Additional Context

at46 commented 3 years ago

Have you tried https://www.steamgifts.com/account/settings/profile?esgst=settings&id=gf_ended?

at46 commented 3 years ago

Not sure why I missed that at first but one giveaway you want to filter is deleted not finished. Deleted giveaways are still shown in the entered list till they reach their original end date and are handled as if they would have some time left to enter. You can try to filter them with https://www.steamgifts.com/account/settings/profile?esgst=settings&id=gf_deleted.

cprn commented 3 years ago

I want to hide both ended and deleted giveaways. I think a giveaway that ended 1 week ago (2nd row on both screens above) should be hidden if I want to show only the giveaways that still have at least 1 minute. 🤷‍♂️

After enabling both options and sorting my "Entered" list I still see giveaways that have already ended: image

at46 commented 3 years ago

I can confirm that using Minutes To End does not filter ended giveaways. However the Ended filter setting is working fine for me and hides all ended giveaways on my entered page.

rafaelgomesxyz commented 3 years ago

As has been pointed out, there are specific Deleted and Ended filters for that, which is why the Minutes To End filter had a restriction that prevented it from working with deleted/ended giveaways, but I'll remove that restriction in the next version.