rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
147 stars 23 forks source link

Game Categories: fix bug that shows recent ratings instead of all ratings #1732

Closed gungfujoe closed 2 years ago

gungfujoe commented 3 years ago

Description Sometime in late July, ESGST started updating game ratings with the "Recent" Steam ratings instead of the "Overall" Steam ratings. This seems to affect more games as time goes on, so I suspect it only kicks in when the rating is updated from ESGST's cache. I still see quite a few games that reflect all ratings in my list, but the majority have either lost their ratings entirely (no recent ratings) or have a much smaller number of ratings (and different percentage) than they should.

Steps to Reproduce

  1. Enable the Ratings game category feature (8.2.26 & 8.2.26.1)
  2. Go to SteamGifts
  3. Look at a game with a rating and rating quantity
  4. Visit the Steam game page
  5. Note that the rating quantity and positive percentage corresponds to

For example, as of this writing, the giveaway for Lovecraft's Untold Stories shows me "90% (10)". When I go to the game's Steam page, I see that there are 10 recent reviews (90% positive) and 483 overall reviews (84% positive)

Expected Behavior The rating and rating quantity should be based on the "Overall" ratings. IN my Lovecraft's Untold Stories example, I should see "84% (483)"

Console Errors None appear relevant (LOTS of themes.js errors that appear to be caused by ForecastFox extension. None appear related to ESGST).

Screenshots SteamGifts page for example game Steam page for example game

Note, the game shows up with the same "recent" ratings on the SteamGifts main page list.

System (please complete the following information):

Additional Context

SteamGifts forum sub-thread on this bug

Thexder0 commented 3 years ago

Just adding a +1 -- I see the same problem here.

Cheers!

JustArchi commented 2 years ago

@rafaelgomesxyz https://github.com/JustArchi/ESGST/commit/203d7dcde9777a427feee9100e482a014b489b61 for this one.

kirara commented 2 years ago

@rafaelgomesxyz JustArchi@203d7dc for this one.

Doesn't work for me :( Still showing only the recent rating.