search

rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
147 stars 23 forks source link

Content Loader->Giveaway Groups fails to load groups for certain giveaways #1744

Open poetickatana opened 2 years ago

poetickatana commented 2 years ago

Description When "Content Loader->Giveaway Groups" is enabled, the groups of certain giveaways fail to load. The problem appears to manifest itself only for giveaways aimed at specific groups. e.g. Giveaways for group "A" will have their groups loaded, but giveaways for group "B" or for groups "A & B" will not.

Steps to Reproduce

  1. Enable ESGST setting 2.6.3 "Content Loader->Giveaway group".
  2. Set ESGST setting 2.6.3.5 "Additional Options" to "Popout (On Click).
  3. Go to a group's Giveaways page. (e.g. https://www.steamgifts.com/group/Kro1T/esgst)
  4. Click on the group icons of various giveaway.
  5. Certain giveaways will display their groups. Other will show "Loading content..." and a spinning circle indefinitely.

Expected Behavior The group list of a giveaway should appear almost instantly after clicking on the group icon.

Console Errors

[ESGST] t.style.backgroundImage.match(...) is null fetchGiveawayGroups@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:88:873522
async*loadGiveawayGroups@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:88:872387
load@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:88:867980
setTrigger/</i<@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:88:867711
setTimeout handler*setTrigger/<@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:88:866010
EventListener.handleEvent*setTrigger@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:88:865959
setTriggers@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:88:864636
giveaways_load@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:88:881171
Async*endless_load@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:1:48214
async*loadFeatures@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:1:41857
async*t@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:88:1151753
async*@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:88:1154138
EventListener.handleEvent*@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:88:1154054
async*@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:88:1154145
@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:88:1154174
n@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:1:110
@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:88:1154263
n@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:1:110
@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:88:1154205
n@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:1:110
@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:1:902
@moz-extension://aeb54d07-d4d9-46ed-9716-2035bca3f882/esgst.js:1:913

Screenshots

Success Loader Success

Failure Loader Failure

System (please complete the following information):

Additional Context Add any other context about the problem here.

JustArchi commented 2 years ago

@rafaelgomesxyz https://github.com/JustArchi/ESGST/commit/5183f5c3c0af9d6954de689a0296ae539d24b40e + https://github.com/JustArchi/ESGST/commit/8d42dff14698ed8504ac6d57ba79f9edbf3f74ea for this issue.

JustArchi commented 2 years ago

And you might also want https://github.com/JustArchi/ESGST/commit/a3b671f29656d1300e4f550cc4ddf4dc91ec29fa along with it.