rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
147 stars 23 forks source link

Clicking on refresh button of active discussions panel placed on top/in sidebar causes unexpected changes to information displayed #1747

Open poetickatana opened 2 years ago

poetickatana commented 2 years ago

Description If "Active Discussions On Top/Sidebar" is enabled, panels with the 10 most recent discussions/deals are displayed when reloading the main steamgifts page. Clicking on the refresh button of these panels causes a few unexpected changes:

Reloading the entire page resets the panels to their original correct view.

Steps to Reproduce

  1. Enable setting "Active Discussions On Top/Sidebar" with Additional Options "Move to" set to "Top"
  2. Reload www.steamgifts.com
  3. Click on the refresh button of either the Discussions of Deals panel.
  4. Observe that (a) number of items displayed changes from 10 to 5 (b) bookmarked threads are no longer marked (c) the panels widths increase.

Expected Behavior Panel height/width and bookmark highlighting should not change when the panels are refreshed.

Console Errors None

Screenshots After entire page refresh After panel only refresh

System (please complete the following information):

Additional Context Add any other context about the problem here.

SquishedPotatoe commented 2 years ago
  • The width of the panels increases (only if they were placed on top using the "move to->top" additional option).

This is a result of the style, i corrected in SGv2-Dark 1.7.0 and SG-Dark-Grey 2.3.4