rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
146 stars 23 forks source link

Probably wrong work of WL/BL checker #48

Closed Diodor7 closed 6 years ago

Diodor7 commented 6 years ago

Based on Steamgifts statistics, I have 14 people in WL. l7oaenb7ssupxzqejs8fga 1

After conducting one of the checks with the parameters "Also check whitelist" and "Check all pages" in one of the steam groups, script identified 29 people who included me in WL. chhn6mnjtyiokotcoib8vg 1

rafaelgomesxyz commented 6 years ago

Did you sync your groups before checking?

rafaelgomesxyz commented 6 years ago

Closing this as I'm quite sure it's because you didn't sync your groups. Let me know if it's still detecting false positives after you sync your groups.

Diodor7 commented 6 years ago

Yes, the groups were sync. Today I again synced the profile, did the check and false positives were repeated.

And, it seems, I found what your mistake was. The script places the user in the category "You are whitelisted by" right after it finds a giveaway that is marked with the Whitelist in which I have access. But besides this there are giveaways that have several marks, for example, "Whitelist" + "Group giveaway"

In other words, if I am in a group for which a giveaway was made, and if this hand has a Whitelist mark, whether the GA creator has whitelisted me or not, he will be placed in the category "You are whitelisted by". I think you did not take into account such a moment that you do not need to approach both the parameters for the access to the giveaway with the Wishlist sign, just one parameter is enough.

tzljsv0nqnk2nq9islntcw 1

I hope I was able to convey to you my idea.

rafaelgomesxyz commented 6 years ago

That's exactly what happens when you don't have your groups synced. The script is designed to check all groups of a giveaway when it is whitelist + group. Try checking the users with the "Clear caches." option enabled.

And it's not the SG sync, it's the script sync in the settings menu.

Diodor7 commented 6 years ago

You were right, I did not sync the groups in the script settings. I thought you mean the sync in the profile. Thanks for reply :)