rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
146 stars 23 forks source link

Fix a bug that happens when syncing giveaways if a giveaway was deleted #506

Closed gizellos closed 6 years ago

gizellos commented 6 years ago

I have endless loop when I want to sync giveaways. I had it in the last stable and it is still in 7.14.5 (Dev.4). There is this error in console:

Uncaught (in promise) TypeError: Cannot read property 'textContent' of null
    at getUgdGiveaways (esgst.js:26596)
    at <anonymous>
rafaelgomesxyz commented 6 years ago

See what the console prints in Dev.7 when you try to sync.

gizellos commented 6 years ago

Dev.8 doesn't say anything. The console is empty and the issue is still there.

rafaelgomesxyz commented 6 years ago

Are you sure? It is impossible for Dev.7 to say nothing, maybe the line that should say something is empty?

gizellos commented 6 years ago

I was sure but it shows something now.

Navigated to https://www.steamgifts.com/discussions
esgst.js:27414 9fNM9
5esgst.js:27414 Opmp7
5esgst.js:27414 aOWML
5esgst.js:27414 qtDWl
5esgst.js:27414 RoFTg
esgst.js:27414 2tc3V
esgst.js:27414 PLwJq
esgst.js:27414 v9SU7
esgst.js:27414 8KdGn
2esgst.js:27414 6ZFsN
2esgst.js:27414 alTRw
2esgst.js:27414 7vHUB
2esgst.js:27414 guX9K
2esgst.js:27414 1WUkh
2esgst.js:27414 bSEX8
2esgst.js:27414 9y1kS
2esgst.js:27414 6gupV
2esgst.js:27414 2E6iK
2esgst.js:27414 QkclL
2esgst.js:27414 U0GbW
2esgst.js:27414 48413
2esgst.js:27414 Sgh2e
2esgst.js:27414 ponL7
2esgst.js:27414 GYPo7
2esgst.js:27414 PPgbk
2esgst.js:27414 wAeYy
2esgst.js:27414 njQfA
2esgst.js:27414 HppvL
2esgst.js:27414 5HWNY
2esgst.js:27414 CTG8U
3esgst.js:27414 4peOu
esgst.js:27417 Uncaught (in promise) TypeError: Cannot read property 'textContent' of null
    at getUgdGiveaways (esgst.js:27417)
    at <anonymous>
gizellos commented 6 years ago

BTW what are the numbers in the circles?

2018-02-22_174408

rafaelgomesxyz commented 6 years ago

Thanks, found the issue, the giveaway was deleted. The numbers in the circle represent how many times the value was printed (for example, in a loop, the same code would be printed as many times as the loop goes on). It basically groups repeated values.