rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
146 stars 23 forks source link

Fix a bug that prevents the script from loading #604

Closed Eiion closed 6 years ago

Eiion commented 6 years ago

The current version master.zip unpacked and loaded in as extension for chrome doesn't work on Steamgifts although being active in extension manager. Here's the error from the console: Uncaught (in promise) TypeError: Cannot read property 'indexOf' of undefined at init (esgst.js:6352)

rafaelgomesxyz commented 6 years ago

Try the latest.

Eiion commented 6 years ago

Tried it with the current 7.17.5 - same problem, same error message. Uncaught (in promise) TypeError: Cannot read property 'indexOf' of undefined at init (esgst.js:6352)

xiaoguanghan commented 6 years ago

hey I have the same issue, I downgrade to 7.17.4 and it works fine. then I upgrade it to the latest and it is still working.

rafaelgomesxyz commented 6 years ago

Should be fixed in the latest dev version.

Eiion commented 6 years ago

No, still not working. When loading it into Chrome I get it tagged with "Error" in the extensions menu. Also, as before, on steamgifts the ESGST button shows up but clicking on it doesn't bring up the ESGST menu. Here's the errors from console:

esgst.js:31800 Uncaught TypeError: Cannot read property 'length' of undefined
    at getOldValues (esgst.js:31800)
    at getFeaturePath (esgst.js:31841)
    at getSMFeature (esgst.js:34246)
    at getSMFeature (esgst.js:34318)
    at getSMFeature (esgst.js:34318)
    at loadSMMenu (esgst.js:34033)
    at HTMLDivElement.<anonymous> (esgst.js:1678)
rafaelgomesxyz commented 6 years ago

Try the latest.

You never mentioned a bug about the ESGST button.

Eiion commented 6 years ago

This one seems to run as intended. The button now works as well.

I kept it short with "doesn't work" - terminatorOST mentioned it though 2 days ago in the forum.

rafaelgomesxyz commented 6 years ago

I missed that. I haven't done my run through the SG thread for the last ~5 pages yet.