Extend header/footer to ESGST-generated pages

rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.

MIT License

147 stars 23 forks source link

Extend header/footer to ESGST-generated pages #646

Closed at46 closed 6 years ago

at46 commented 6 years ago

TypeError: context is undefined  esgst.js:32326:5
Utils: Failed to serialize principal '[xpconnect wrapped nsIPrincipal]' [Exception... "Could not convert JavaScript argument arg 0 [nsISerializationHelper.serializeToString]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: resource://gre/modules/sessionstore/Utils.jsm :: serializePrincipal :: line 126"  data: no]

FF59 with ESGST addon 7.17.8.

rafaelgomesxyz commented 6 years ago

Can you check if it still happens in v7.18.1?

at46 commented 6 years ago

Still the same with 7.18.1. Only the number changed: TypeError: context is undefined esgst.js:39952:5

rafaelgomesxyz commented 6 years ago

Does this prevent the menu from opening or does the menu open fine?

rafaelgomesxyz commented 6 years ago

If it opens fine, can you detect anything that might be missing?

at46 commented 6 years ago

Settings menu opens fine and as far as I can see / have used the settings everything is there and works as intended. Error is still there with 7.19.0:

TypeError: context is undefined  esgst.js:40465:5
Utils: Failed to serialize principal '[xpconnect wrapped nsIPrincipal]' [Exception... "Could not convert JavaScript argument arg 0 [nsISerializationHelper.serializeToString]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: resource://gre/modules/sessionstore/Utils.jsm :: serializePrincipal :: line 122"  data: no]

rafaelgomesxyz commented 6 years ago

Still an issue? I cannot reproduce at all. Would be helpful if you shared your settings so I can try to reproduce.

at46 commented 6 years ago

With 7.20.5:

TypeError: context is undefined  esgst.js:39634:5
Utils: Failed to serialize principal '[xpconnect wrapped nsIPrincipal]' [Exception... "Could not convert JavaScript argument arg 0 [nsISerializationHelper.serializeToString]"  nsresult: "0x80570009 (NS_ERROR_XPC_BAD_CONVERT_JS)"  location: "JS frame :: resource://gre/modules/sessionstore/Utils.jsm :: serializePrincipal :: line 122"  data: no]

esgst_settings_2018-06-04T20_47_28.504Z.zip

Since everything seems to work I would consider this low priority

rafaelgomesxyz commented 6 years ago

Please post the output from the console in the latest version.

at46 commented 6 years ago

The output changed with 7.22.0 console.txt

rafaelgomesxyz commented 6 years ago

Oh, wait, this error only happens when you open the actual settings page (https://www.steamgifts.com/esgst/settings)? Not when you open the popup through the normal SG pages?

at46 commented 6 years ago

No error when using the popup but error when using the new tab. I thought I had that written in my first post but seems I missed to clarify it completely. I always use 8.20 "Open settings menu in a separate tab". Sorry that I forgot to mention that.

rafaelgomesxyz commented 6 years ago

Ah ok, then I have that error as well. It's because it doesn't find a header to insert the ESGST button in that page. I'll fix it for the next version.