rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
146 stars 23 forks source link

Version 7.19.0 - issues with page scaling #714

Closed Eiion closed 6 years ago

Eiion commented 6 years ago

There's an issue with how the page gets scaled after updating to the current public version:

This is how it looks on the "All", "Whislist", "Recommended", "Group" and "New" pages: (picture removed) Quite a lot gets cut off on the right (Buttons, part of the pictures) - although there's plenty of screen estate.

After scrolling to the right, it looks like that - with the blue backgroun: (picture removed) And when not scrolling to the right but just down, so much that the next ending giveaway advertised on the very top is out of the window it rescales to that: (picture removed) Everything on the right is visible again, without scrolling to the right, but the menu on the left lays over the list of giveaways, while taking up way too much space anyways with the long dotted lines that the search box.

The only steamgifts related message in console that I'm getting is this: Mixed Content: The page at 'https://www.steamgifts.com/' was loaded over HTTPS, but requested an insecure image 'http://cdn.edgecast.steamstatic.com/steamcommunity/public/images/avatars/62/621e48d930571ebf730415bce24381a25dc7d7f8_medium.jpg'. This content should also be served over HTTPS.

rafaelgomesxyz commented 6 years ago

That always happens when there's too much stuff in the giveaway line though, which is why the default position of the chance/enter buttons is below the start time and the default position of game categories is below the name of the game. If you disable Accurate Timestamps, which takes a lot of space, it should go back to normal.

Eiion commented 6 years ago

1, The problem didn't exist (for me) before this version. 2, That doesn't really explain why all fits on nicely once the advertised GA is out of the view (apart from the overlay error of the menu on the left). 3, If the search bar on the left wouldn't be as huge but only as big as the word "Recommended" and also if these looong dotted lines were gone (which nobody needs in the first place) the problem would be solved, I guess. Either way, it all worked fine with the same settings before the update I did today.

rafaelgomesxyz commented 6 years ago

Oh, I didn't notice the last screen is normal.

Well, I'll see if I can find something, because I'm not able to reproduce it.

rafaelgomesxyz commented 6 years ago

Actually, I was just able to reproduce it right now and it's indeed because there are too many things in the giveaway line. Perhaps you didn't notice before because the line never got that big, but it was probably just a coincidence that you noticed it in the latest version.

Eiion commented 6 years ago

The problem definitely didn't exist before (for me) - I know since the "Continuously Load Pages"-Button is one of the most used things altogether on the page (again, for me). Maybe CG changed something if you didn't, but this first showed up after updating to version 7.19.0. This morning, before I updated to 7.19.0 everything still was as it should be.

rafaelgomesxyz commented 6 years ago

Still, it might have been that there just wasn't any giveaway in the page causing issues. It happens on every single page?

From the screenshot you posted it definitely looks like there wouldn't be enough room to fit all of that in the screen, so I don't see how this wouldn't happen in previous versions.

Did you try disabling Accurate Timestamps or moving some elements out of the time column to see if it goes back to normal?

Eiion commented 6 years ago

I've just updated to 7.19.1 (Dev.13) - same with that version. It happens on all the pages listed on the first post. Disabling accurate timestamp fixes it but that's only a workaround for something that wasn't a problem before.

What you seem to miss is the info (and screenshot) I gave regarding the advertised giveaway at the very top. I might be wrong but to me it seems that the games picture is bigger than it was before. Again, as soon as that advertised Giveaway (the featured outer wrap) is scrolled out of the way, everything that is right from the window moves back in view no matter the timestamps.

Apart from that, would you be able to shorten that search bar on the left and remove the dotted lines?

rafaelgomesxyz commented 6 years ago

Is it possible for you to downgrade to v7.18.0 or earlier to double check?

It moves back into view when you scroll down because the content goes more to the left than it should (which is why the sidebar overlaps). If the sidebar didn't overlap it would stay the same while scrolling, without enough room to fit all of the elements in the page.

Apart from that, would you be able to shorten that search bar on the left and remove the dotted lines?

Yes, that is possible.

Eiion commented 6 years ago

Sure, I can try that.

rafaelgomesxyz commented 6 years ago

Thanks, if you could find a more static page (with giveaways that aren't ending soon so that when you refresh it, it's the same page), you could post one identical screenshot from the current version and from the previous version for better comparison.

Eiion commented 6 years ago

In the meantime I tried 7.18.2 and already went back to the current version twice before reading your new post.

Turns out the that I was wrong about something and that the issue is a different one: While having accurate timestamp activated I'm having an exclude filter set for accurate time stamp ^/($|giveaways(?!/(new|wishlist|created|entered|won))) that actually works with 7.18.2 - but with the same exact backup file it doesn't even show up in the settings in the new versions. Meaning, with the new version the exception rule simply is gone.

I have no memories on how that rule made it into my settings. No idea if it was there to begin with or if a friend of mine gave it to me and I copy/pasted it in... months back. I don't understand exactly what it means and would assume that the accurate timestamp is excluded from the new/whishlist/created/entered/won pages - but actually the accurate timestamp shows up on the created/entered/won pages - while it doesn't on all/recommended/whislist/group/new with version 7.18.2. Anyways, the new issue is, why versions 7.19.x don't even show the exclude rule in the settings while it's there with previous versions.

rafaelgomesxyz commented 6 years ago

Ah ok, there was a bug with some excludes that was fixed in the recent version. As a result, some settings had their values altered.

rafaelgomesxyz commented 6 years ago

I have no memories on how that rule made it into my settings. No idea if it was there to begin with or if a friend of mine gave it to me and I copy/pasted it in... months back. I don't understand exactly what it means and would assume that the accurate timestamp is excluded from the new/whishlist/created/entered/won pages - but actually the accurate timestamp shows up on the created/entered/won pages - while it doesn't on all/recommended/whislist/group/new with version 7.18.2. Anyways, the new issue is, why versions 7.19.x don't even show the exclude rule in the settings while it's there with previous versions.

That setting was not in your settings file. It's the default setting that ESGST should activate if you used to have "Enable for giveaways." disabled under "Accurate Timestamps" before includes/excludes were implemented. The issue is that ESGST was activating that default setting for all users, instead of just the users who had "Enable for giveaways." disabled. That was fixed in v7.19.0 or the one before, I don't remember. So now all those default settings are gone for users that they should not have been activated in the first place, it's not an issue.

rafaelgomesxyz commented 6 years ago

Ok, so since there isn't really an issue, I'll just close this.

Your suggestion for smaller sidebar: #715