search

rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
147 stars 23 forks source link

Show game categories for packages of the items from the package #786

Closed gungfujoe closed 6 years ago

gungfujoe commented 6 years ago

I've been noticing that in compilation games, like "Complete Edition" packs that include the game and DLC, even when trading cards are present, they're not detected by ESGST. For example: https://www.steamgifts.com/giveaway/PC1Bo/zombie-driver-hd-complete-edition

(This game has trading cards, but shows up on SteamGifts as not having trading cards)

rafaelgomesxyz commented 6 years ago

Well, packages themselves don't have trading cards, so it's not that it doesn't work, it's that it's not supposed to work. Packages don't offer a lot of information about the games inside of them.

gungfujoe commented 6 years ago

I'm referring to packages where the Steam store page for them does offer that information. For the game linked above, if ESGST is getting the info form the Steam store page, it should be able to find the trading cards:

image

rafaelgomesxyz commented 6 years ago

Steam probably shows that based on the apps that are on it (the trading cards are not tied to the package, but to the apps in the package).

ESGST uses the Steam store API: https://store.steampowered.com/api/packagedetails?packageids=48344 Retrieving that additional info from the store page would mean more requests, which is slower, and requests to the API are more reliable.

I'll think about what else I can do.

gungfujoe commented 6 years ago

Understood. If it's an API limitation, there may be nothing you can do within reason. Regardless, I appreciate the prompt responses, and I also appreciate all of the work that's clearly gone into this impressive script!