Fix a bug that does not sort some columns correctly in Table Sorter

rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.

MIT License

147 stars 23 forks source link

Closed Eiion closed 6 years ago

Eiion commented 6 years ago

On the "Entered page" sorting for "Date Entered" ist not working.

Error: Uncaught TypeError: Cannot read property 'getAttribute' of null at ts_getArray (esgst.js:37779) at ts_sortTable (esgst.js:37737)

Eiion commented 6 years ago

On another note, the table sorter also (still) doesn't work correctly when on (example) https://www.steamgifts.com/group/ABCDE/yxz/users and sorting for (in this case) "Value Difference": https://i.imgur.com/O4mV1jc.jpg I'd assume this is due to not correctly recognizing the comma.

rafaelgomesxyz commented 6 years ago

Can you confirm that this only happens if there is a deleted giveaway in the page?

Eiion commented 6 years ago

I can confirm that sorting by "Date Entered" is not working when there's deleted giveaways on the page and vice versa.