rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
147 stars 23 forks source link

Entered GAs page has bad table layout #972

Closed cassolv closed 6 years ago

cassolv commented 6 years ago

Description 8.0 introduced an issue with the entered GAs page due to which the GA column takes way too little space and becomes horrible.

Steps to Reproduce https://www.steamgifts.com/giveaways/entered (you may need to turn some options on).

Expected Behavior A decent-looking table where every GA doesn't take literally 400+ vertical pixels and 200 horizontal ones while the entire rest of the table is swimming in empty space.

Console Errors At the end because markdown is not letting me close the codeblock for some reason.

Screenshots Entered GAs page:

image

Console errors in screenshot format for readability:

image

System

Additional Context N/A

Console errors:

userscript.html?id=8…35b-8d996ab01a81:49 TypeError: Cannot read property 'bind' of undefined
    at t.value (userscript.html?id=8…35b-8d996ab01a81:49)
    at t.value (userscript.html?id=8…35b-8d996ab01a81:49)
    at t.eval (userscript.html?id=8…35b-8d996ab01a81:49)
    at _ (userscript.html?id=8…5b-8d996ab01a81:219)
    at Generator.eval [as _invoke] (userscript.html?id=8…5b-8d996ab01a81:219)
    at Generator.e.(anonymous function) [as next] (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:219:12285)
    at n (userscript.html?id=8…35b-8d996ab01a81:49)
    at r (userscript.html?id=8…35b-8d996ab01a81:49)
50
userscript.html?id=8…35b-8d996ab01a81:49 ESGST Log: CEWGD 1
userscript.html?id=8…35b-8d996ab01a81:49 DOMException: Failed to execute 'appendChild' on 'Node': The new child element contains the parent.
    at t.value (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:49:1352388)
    at eval (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:49:1375034)
    at Array.forEach (<anonymous>)
    at t.eval (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:49:1374981)
    at _ (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:219:12106)
    at Generator.eval [as _invoke] (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:219:11894)
    at Generator.e.(anonymous function) [as next] (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:219:12285)
    at n (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:49:354129)
    at r (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:49:354339)
    at <anonymous>
userscript.html?id=8…35b-8d996ab01a81:49 Uncaught (in promise) DOMException: Failed to execute 'appendChild' on 'Node': The new child element contains the parent.
    at t.value (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:49:1352388)
    at t.value (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:49:583714)
    at t.eval (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:49:545687)
    at _ (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:219:12106)
    at Generator.eval [as _invoke] (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:219:11894)
    at Generator.e.(anonymous function) [as next] (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:219:12285)
    at n (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:49:354129)
    at r (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:49:354339)
    at eval (chrome-extension://dhdgffkkebhmkfjojejmpbldmpobfkfo/userscript.html?id=80e82f6b-5996-4dfa-b35b-8d996ab01a81:49:354398)
    at new Promise (<anonymous>)
50
userscript.html?id=8…35b-8d996ab01a81:49 ESGST Log: CEWGD 1
rafaelgomesxyz commented 6 years ago

Please check if v8.0.2 fixes this.

cassolv commented 6 years ago

Nope, still happening. And I just noticed it also affects the created and won pages. In case that matters, I upgraded to Vivaldi 2.0 (Chromium 69) shortly after posting this report and confirmed that nothing had changed with the upgrade.

cassolv commented 6 years ago

Oops, my bad, it does fix it, and for all three pages. It turns out the update had failed and I thought it had succeeded (I hadn't actually checked because my computer was lagging like hell). I suppose #975 did it?

Thanks! :+1: