search

rafaelklaessen / keep-clone

An effort to make a clone of Google Keep in play-scala with Firebase.
Other
16 stars 6 forks source link

Sensitive information #4

Closed Titogelo closed 7 years ago

Titogelo commented 7 years ago

This is project is a playground, but we need to be careful to not add sensitive information to github.

One example is this json config file with all the secrets and token for firebase ;)

https://github.com/rafaelklaessen/keep-clone/blob/master/app/keep-clone-840b5-firebase-adminsdk-ztnub-40397c0ba3.json

rafaelklaessen commented 7 years ago

I'll remove the JSON file and database secret in the Users model.

Titogelo commented 7 years ago

Hey man!

Get some rest ; ) It is weekend.

You are a really hard worker!! But we also need to rest haha

See u!

Best, Angel.

On Feb 11, 2017 23:21, "Rafael Klaessen" notifications@github.com wrote:

I'll remove the JSON file and database secret in the Users model.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/rafaelklaessen/keep-clone/issues/4#issuecomment-279180089, or mute the thread https://github.com/notifications/unsubscribe-auth/ABhkqNCQwdMk49_YwzlHVbfmGS85pKJnks5rbjSAgaJpZM4L-S-E .

rafaelklaessen commented 7 years ago

Yeah, well, my local git repo's going crazy. I'll look at it tomorrow then.

Titogelo commented 7 years ago

Why is it going crazy? I know that sometimes git can give you some headaches... be patient 👍

rafaelklaessen commented 7 years ago

I had a detached head because I didn't sync your changes... I just backed everything up and recloned the repo. It works now :)

Titogelo commented 7 years ago

Yep, I understand you problem and it is completely fine to have them, so don't worry :).

Below some tips.

Whenever you work in a collaborative project, you always need to have in mind that more people will be working with your code and also, think that more people might be actually changing other parts of the code while you work. So lot of things can occur in parallel.

That's why whenever you want to push something to the Github repository you first need to check if there are changes from other team members.

git pull origin master => to download and merge changes from other people should be okay.

Talk to you later!

JetseVerschuren commented 7 years ago

The json file is still online. https://github.com/rafaelklaessen/keep-clone/blob/4d9c35843b581b9aaa62a1a9b4d60a4bf4ed4172/app/keep-clone-840b5-firebase-adminsdk-ztnub-40397c0ba3.json