full screen on load - Githubissues

rafaelklaessen / react-tradingview-widget

React component for rendering the TradingView Advanced Real-Time Chart Widget.

MIT License

273 stars 94 forks source link

full screen on load #24

Closed amlcodes closed 5 years ago

amlcodes commented 5 years ago

full screen on load

AurelReb commented 5 years ago

I found a fix. You can use it by importing my fork of this library:

npm install AurelDev/react-tradingview-widget --save or
yarn add AurelDev/react-tradingview-widget

rafaelklaessen commented 5 years ago

Hi, could you be a bit more specific? I've no clue what you mean.

@AurelReb if you'd like to, perhaps you could create a PR and then I can merge your fix into this repo?

AurelReb commented 5 years ago

Actually it is a rare bug which appears when the TradingViewWidget component is unmounted before the chart is rendered. Therefore the chart is rendered after in full screen in the body element. I'll create a PR with my fix soon

rafaelklaessen commented 5 years ago

Merged, thanks!