search

rafaelleru / torrent-player

Electron music player
https://gitter.im/torrent-player/Lobby?utm_source=share-link&utm_medium=link&utm_campaign=share-link
MIT License
14 stars 10 forks source link

[WIP] Add Settings component #36

Closed karatakis closed 2 years ago

karatakis commented 7 years ago

selection_031

karatakis commented 7 years ago

It is just the UI, we can wire the settings to a global store, so every component can access the settings.

rafaelleru commented 7 years ago

Yeah it's a good first aproach and yes we will put the settings in a store, you can go ahead if you like, but I was thinking in a whole page for setings instead of a popup, can you make a complete page and display it when the button is clicked?¿

karatakis commented 7 years ago

I can work on that tommorow, and I will try to create a Vuex store along with it

rafaelleru commented 7 years ago

ok, thanks 😸

karatakis commented 7 years ago

I will use vue-router to implement the transition to different pages, is there any way to perform routing in electron ?

karatakis commented 7 years ago

After I added the vue-router, The electron hot reloading makes the application not to render correctly. I don't know what I messed up :cry: selection_001 It shows perfectly the dom nodes, but the screen is white.

rafaelleru commented 7 years ago

Really, it is so weird. Do you have any other instanceof torrent player running?

rafaelleru commented 7 years ago

Are you still working on this? @karatakis

karatakis commented 7 years ago

I am working this during weekends. Are you planing to use Vue-router in the future ?

rafaelleru commented 7 years ago

Yes, I was looking and vue-router seems to be what we need. 😀