search

rafaelmaiolla / remote-vscode

A package that implements the Textmate's 'rmate' feature for Visual Studio Code.
MIT License
260 stars 33 forks source link

Closing file do not work anymore. #26

Open thierrymichel opened 7 years ago

thierrymichel commented 7 years ago

Hi,

First fo all, thanks for this extension!

Since the april update (not completely sure about the date), I need to close the window to end properly the rmate process. Previously, it was working when closing the file (which is more convenient than closing and reopening VSC every time). Any idea ?

VSC version 1.12.2 MacOS Sierra 10.12.5 rmate 1.5.9 (2017-02-10) on linux

Thanks

thierrymichel commented 7 years ago

It fails when using rmate -w (for git commit messages, for example)

rafaelmaiolla commented 7 years ago

I didn't test this this scenario. So, I'm not surprise if it doesn't work. I will investigate the issue.

sarim commented 7 years ago

@rafaelmaiolla Any progress in this? I'm having the same issue.

rafaelmaiolla commented 7 years ago

There is something wrong with VSCode. It is not calling onDidCloseTextDocument as expected. So, it is not possible to identify that the file is closed.

In my tests, it is taking 3 min for the VSCode to call the onDidCloseTextDocument. I'll need to check if there is anything open regarding this issue.

rafaelmaiolla commented 7 years ago

I open an issue for vscode https://github.com/Microsoft/vscode/issues/30820

sarim commented 7 years ago

While that is being sorted out, maybe you can create a new command >Remote: Close All Files. The command will close any editor tabs open via remote and close files properly.

rafaelmaiolla commented 7 years ago

It seems that it stop working in version 1.13.1.

Version 1.12.2 is working as expected.

LukeIreland1 commented 5 years ago

@rafaelmaiolla Where did you get up to with this? I want to use VS Code as my Git Editor. Currently works fine for editing files normally, but using rmate -w as Git Editor doesn't send the edit back to the server/ssh session, and just hangs.

rafaelmaiolla commented 5 years ago

@LukeIreland1, last time I investigated this, it was an issue in VS Code. Something changed there and the related functions were not being called when that was closed. I opened a ticket for them, but it was closed.

romanmar commented 3 years ago

@rafaelmaiolla Where did you get up to with this? I want to use VS Code as my Git Editor. Currently works fine for editing files normally, but using rmate -w as Git Editor doesn't send the edit back to the server/ssh session, and just hangs.

I've ended up changing the python version of rmate client, by adding tm_sock.settimeout(60 * 60 * 24) as a kludge to kill rmate after 24 hours.