search

rafaelmaiolla / remote-vscode

A package that implements the Textmate's 'rmate' feature for Visual Studio Code.
MIT License
260 stars 33 forks source link

Open Multiple Files at Once #63

Open ComfyDust opened 6 years ago

ComfyDust commented 6 years ago

Hey Rafael,

This pull request mostly solves issue #43 . Summary:

  1. preview is set to false in the call to showTextDocument() so that multiple files can be opened simultaneously without disabling workbench.editor.enablePreview globally in VS Code.
  2. Instances of RemoteFile and Command associated with the Session class are stored in arrays to allow multiple files to be sent in a single session.
  3. Some array references that were added were subsequently replaced with local method variables for readability.

Unfortunately, number 2 only works most of the time. Occasionally only the first file is opened, so I highly suspect there's a race condition somewhere.

Cheers!

github-jane-doe commented 5 years ago

@ComfyDust Is it possible for me to try your fix and actually edit multiple files at once?

ComfyDust commented 5 years ago

@github-jane-doe It's technically possible but it might be a bit of a pain since you would have to launch the extension in an extension developer workspace whenever using it. Since creating this PR I've personally switched to using the official remote VS Code extension packs when working on code stored remotely or in the WSL.

github-jane-doe commented 4 years ago

@github-jane-doe It's technically possible but it might be a bit of a pain since you would have to launch the extension in an extension developer workspace whenever using it. Since creating this PR I've personally switched to using the official remote VS Code extension packs when working on code stored remotely or in the WSL.

Unfortunately, as far as I know, the remote VS Code extension does not work on macOS

ComfyDust commented 4 years ago

Hmmm, the SSH docs seem to suggest that, while you can't connect to macOS servers, you should be able to connect from a mac.

macOS SSH hosts are not yet supported. (macOS clients are supported.)

Afraid I don't have a mac myself so I can't poke about to confirm.