search

rafaelmardojai / blanket

Listen to different sounds
GNU General Public License v3.0
1.33k stars 103 forks source link

Feature Request: Change names of custom sounds in-app #337

Open MMachado05 opened 5 months ago

MMachado05 commented 5 months ago

I like to find different study sounds on sources like YouTube and SoundCloud, then download them with something like Video Downloader to import into Blanket for offline use. However, Blanket just uses the original filename to name the sound, and sometimes the name of the video or "song" might be something incredibly long and overly descriptive. As a recent example, this sound I like is called "Thunder & Rain With Ocean Sounds (75 Minutes)." I'd much rather just call it something like "Stormy Ocean," but forgetting I can't rename sounds in the app, I'll go to my download location, have to rename the file there, then import it.

It becomes a little more inconvenient when I decide that the name isn't as descriptive as I wanted it, or maybe a friend uses my machine and the name isn't as intuitive. If I wanted the same sound to have a different name, I would have to delete the current one, rename the file on my filesystem, then import it again. I think having an "edit custom sound" feature might make this a lot more straightforward.

tmdag commented 4 months ago

same with Icons, would love to be able to add my own icon to newly loaded sound

tmdag commented 4 months ago

Screenshot from 2024-04-19 11-00-13 This is how my app looks like at the moment - if I could at least choose icon from existing ones, that would be great :)

MMachado05 commented 4 months ago

This would also definitely be useful! I only have 2 custom sounds so I didn't realize how difficult it might be when managing multiple custom ones.

Also, while I like the UX refresh, I think clumping them all together like that makes them a bit hard to find. I might make a new Issue asking for the ability to organize different sounds into "categories" (i.e. nature, shops, static, etc.) which might make the UX even cleaner!

rubenmvc commented 1 month ago

Hi everyone! I made an attempt to implement this functionality as you can see here, and for now it works except for two little issues that I'm trying to solve:

Screencast from 2024-07-17 20-35-50.webm

  1. The label of the sound item is not reloaded/refreshed unless you close and reopen the application. Is there a way to update the widget? I'm trying but for some reason I can't do it.
  2. The renamed item goes to the bottom of the list. I think the reason is that you can't change the key of the item dict in an easy way (unless if it was some kind of ordered dict, but that's not the case). I know that maybe I could recreate the entire custom audio list, but I hope that no user will add hundreds of files and it affects performance.

If I can solve at least one of these problems, I could create a fork and MR to be reviewed but until that, any suggestion is welcome.