missing gap in between tab bar and favourites bar

[nanopone]

Describe the bug the margin between the tab and the favourites bar is non-existent. this looks fine normally, but if the colour of the favourites bar or tab bar is changed, it's very jarring. this is notably changed by gradience, which technically makes this a gradience problem, however almost literally any change to the colour scheme via gradience would show this problem. i, myself, am using the stock adwaita dark theme provided by gradience with only the accent colour changed, and this issue affects me. even though it is not noticeable by people using the stock theme, it is still there and in my opinion is still a problem.

To Reproduce

1. install the theme
2. using customChrome.css, change the colour of the favourites/tab bar. you can also use gradience
3. observe

Expected behavior the gaps around the tabs should be uniform

Screenshots

Setup information

• OS: fedora workstation 39
• Installation method: flatpak
• Firefox version: 120.0
• Theme version: v120
• Optional features enabled: gnomeTheme.hideSingleTab, gnomeTheme.hideWebrtcIndicator

[nanopone]

update: turns out this is kind of noticeable without any customChrome. take specific note of the separators for the favourites and the tabs. the gap between the favourites separator and the address bar is different than the gap between the tab separator and the favourites separator:

[rafaelmardojai]

True, the bookmarks bar should have no top padding.

[nanopone]

True, the bookmarks bar should have no top padding.

what? no. i'm saying there's no padding on the top of the tab bar where there should be. i'm not saying to remove the padding on the top of the bookmarks bar, that would just introduce yet another visual problem.

[rafaelmardojai]

what? no. i'm saying there's no padding on the top of the tab bar where there should be. i'm not saying to remove the padding on the top of the bookmarks bar, that would just introduce yet another visual problem.

Well, with the GNOME 45 style you're supposed to have a single color background in the whole top toolbars without divisions.

For example here you have the theme and GNOME Web bellow:

[rafaelmardojai]

If the problem is that when you apply different background colors, you see the non-existent top padding of toolbars below the header bar, that's not supported. They don't have top padding to have the correct spacing like other GNOME applications. So I would suggest adding padding to them in your customChrome.css if you want to change the backgrounds.