search

rafaelmardojai / firefox-gnome-theme

A GNOME👣 theme for Firefox🔥
The Unlicense
3.42k stars 157 forks source link

Not sure if a bug or not - tab close button is now on left side #702

Closed mikoducky closed 9 months ago

mikoducky commented 9 months ago

Describe the bug The tab close button is now on the left side of tabs instead of the right.

To Reproduce

  1. Install theme with curl script or autoinstall
  2. That's it.

Expected behavior The close button for tabs should be on the right side of the tab.

Setup information

mikoducky commented 9 months ago

I just found out that the close on the tab is linked to what side your window close button is. I don't remember it being that way just a couple days ago... Could we maybe have a feature to enable changing the side you want that on without affecting the window buttons placement?

rafaelmardojai commented 9 months ago

Yep, the behavior changed some months ago (this commit 8c9db7a9cdd2012868e0fc97b329d1f2a7af9823), it has been a long standing request.

I implemented it like that because GNOME Web behaves like that, although other GNOME apps with tabs like Files or Console don't seem to be consistent with that behavior. Another reason is that "left close button" users seemed to agree about having the tabs button in the left too, but looks like I was wrong 😅.

mikoducky commented 9 months ago

I'm great at being contradictory. I just think it looks weird, especially when being on the first tab, as the close buttons end up being awkwardly stacked. How much of a pain would it be to have it as a optional feature to enable in the about:config? Like, the value would literally just flip the side it's currently on, not even specify which one.

And besides that, I use Firefox on my work computer, which has the tab buttons on the right side. Do that all day, then come home, and suddenly they're on the opposite. It feels weird and you question your sanity.

Finally, I wonder if my install never updated properly or something, as I promise that button was on the right just a couple days ago. I would have to verify by plugging my old drive back in, though...

rafaelmardojai commented 9 months ago

Added the gnomeTheme.swapTabClose pref, it will swap the position of the tab close button that by default follows the window controls position.

mikoducky commented 9 months ago

Added the gnomeTheme.swapTabClose pref, it will swap the position of the tab close button that by default follows the window controls position.

Works great. Thanks so much!