search

rafaelmardojai / firefox-gnome-theme

A GNOME👣 theme for Firefox🔥
The Unlicense
3.4k stars 155 forks source link

Muted text will use wrong colors #717

Closed CleoMenezesJr closed 8 months ago

CleoMenezesJr commented 8 months ago

If anyone is interested in starting to contribute, something easy to do:

image

The colors should look like this: image

PD: this happens in both dark and white mode.

Sidd-77 commented 8 months ago

Can you assign this to me, I'm working on it...

Sidd-77 commented 8 months ago

image

its already looks good also I didn't find any css for text, everything was for background color

CleoMenezesJr commented 8 months ago

Really nice. How is it looking like on white mode? Open a PR, please.

Sidd-77 commented 8 months ago

I haven't changed anything I'm saying its already good...

CleoMenezesJr commented 8 months ago

I haven't changed anything I'm saying its already good...

Are you using nightly branch?

rafaelmardojai commented 8 months ago

I'm using Firefox Stable and can see the issue.

These should be the lines affecting the shorcuts, it's just opacity: https://github.com/rafaelmardojai/firefox-gnome-theme/blob/d2e6cfdd63651ae8168e5905d94138f406580dd6/theme/parts/popups.css#L202-L204

Sidd-77 commented 8 months ago

@CleoMenezesJr sorry my bad i was using master branch

rafaelmardojai commented 8 months ago

I have the feeling that Firefox changed the base colors of those shorcuts, so the opacity now is too much.

The possible solutions are to force the color to be --gnome-menu-color or adjust the opacity to the new color.

CleoMenezesJr commented 8 months ago

This works fine:

.subviewbutton[shortcut]:after { 
    color: var(--gnome-menu-color) !important;
}
CleoMenezesJr commented 8 months ago

Well, I'll make a commit of this.