Large context menus have broken scrolling

rafaelmardojai / firefox-gnome-theme

A GNOME👣 theme for Firefox🔥

The Unlicense

3.4k stars 155 forks source link

Large context menus have broken scrolling #728

Closed AbrarSL closed 7 months ago

AbrarSL commented 8 months ago

Describe the bug

Clicking on an element that produces a long context menu (Image that is also a link) will produce a glitchy context menu. The number of items in the menu is too long and tries to scroll but the scroll mechanism seems broken.

To Reproduce

Go to flathub.org
Right click on an app icon that is just about low enough to have the context menu overflow the window
See error

Expected behavior

Not be glitchy. Scroll properly the same way GTK4 popovers do.

Screenshots

Example

Setup information

OS: Fedora Silverblue 39
Installation method: Flatpak
Firefox version: 121
Theme version: master
Optional features enabled: gnomeTheme.hideSingleTab

CleoMenezesJr commented 8 months ago

Yeah, can reproduce since v120.

Thorazin commented 8 months ago

Yep, I started having this problem today and the only solution I can find so far is to uninstall the theme.

CleoMenezesJr commented 8 months ago

I'm a bit out of time to look into this right now, but messing around a bit with --panel-shadow-margin seems to remove the problem, so there is some margin that is conflicting with this.

ulipo commented 8 months ago

I have the same issue with bookmarks menu, it jumps around like in the screencast above. The issue has been introduced with commit 32b535c , reseting to 54433bf makes it disappear.

oktayacikalin commented 7 months ago

The dirty workaround from @ilsubyeega works. Not pretty, but the context menu is usable again. Hope you'll figure it out. :four_leaf_clover:

rafaelmardojai commented 7 months ago

I'm back from vacations, will check it out soon.

The problem is caused by our tabbar scrolling special theming, and because Firefox uses shadow DOM here, it looks like we're affecting all the scroll boxes, including the menu ones.

Thorazin commented 7 months ago

Thank you for the fix. I do like this theme. I want to let you and others know though that the "One command install with curl" did not download the fixed files, however cloning the git and running the install script did and now it works.

queeup commented 7 months ago

Yea he will release new version then we can install this fix with curl. Because one command install is installing latest release version.