Closed AbrarSL closed 7 months ago
Actually checking libadwaita we want to use the colors from headerbar_darker_shade_color
which is set to:
@define-color headerbar_darker_shade_color #{if($variant == 'light', transparentize(black, .88), transparentize(black, .1))};
That will be rgba(0, 0, 0, 0.12)
for light and rgba(0, 0, 0, 0.9)
for dark.
The coloring issue should be fixed be fixed by giving #navigator-toolbox
a background (--gnome-toolbar-background
).
Actually checking libadwaita we want to use the colors from
headerbar_darker_shade_color
which is set to:@define-color headerbar_darker_shade_color #{if($variant == 'light', transparentize(black, .88), transparentize(black, .1))};
That will be
rgba(0, 0, 0, 0.12)
for light andrgba(0, 0, 0, 0.9)
for dark.The coloring issue should be fixed be fixed by giving
#navigator-toolbox
a background (--gnome-toolbar-background
).
Is it okay now?
@AbrarSL Yes, but better update the --gnome-headerbar-shade-color
var to these colors, we don't have a use case for the non darker version.
--gnome-toolbar-background: var(--gnome-headerbar-background);
and --gnome-toolbar-color: var(--gnome-window-color);
seems unnecessary too? Shall I just get rid of them and directly use the variables they point to?
@rafaelmardojai
@AbrarSL --gnome-toolbar-background
should stay for semantics, but --gnome-toolbar-color
can be removed since I don't think we ever will have divergence of colors there.
@rafaelmardojai Done.
Thanks a lot for taking the time!
This makes it look identical to the border in GNOME Web.