rafaelmardojai / firefox-gnome-theme

A GNOME👣 theme for Firefox🔥
The Unlicense
3.4k stars 155 forks source link

Tabs bar overflow arrows invisible #749

Closed somepaulo closed 7 months ago

somepaulo commented 7 months ago

Describe the bug The tabs bar overflow arrows have disappeared a couple of updates ago.

To Reproduce

  1. Open enough tabs to overflow the tabs bar.
  2. Look for overflow arrows on either side of the tabs bar.
  3. Not see them.

Expected behavior When the tabs bar overflows, arrows should appear on either side of the tabs bar (except the side that is fully scrolled to an end).

Screenshots How it is Screenshot from 2024-01-17 12-07-41

How it should be Screenshot from 2024-01-17 12-07-53

Setup information

Additional context The CSS applied to the arrow images (in tabsbar.css, line 59) is still used when the arrows should be displayed:

#scrollbutton-up:has(~ .scrollbox-clip[orient="horizontal"]) > .toolbarbutton-icon, .scrollbox-clip[orient="horizontal"] ~ #scrollbutton-down > .toolbarbutton-icon {
  visibility: hidden;
}

Adding this solves it for me:

#scrollbutton-up:has(~ .scrollbox-clip[orient="horizontal"]):not([disabled]) > .toolbarbutton-icon, .scrollbox-clip[orient="horizontal"] ~ #scrollbutton-down:not([disabled]) > .toolbarbutton-icon {
  visibility: visible;
}
rafaelmardojai commented 7 months ago

This is an intentional change to mimic libadwaita tabs. You still can click the fade to scroll, or use you mouse wheel.

somepaulo commented 7 months ago

OK then. Thanks for the explanation.