rafaelmardojai / firefox-gnome-theme

A GNOME👣 theme for Firefox🔥
The Unlicense
3.32k stars 153 forks source link

Sharp corners #762

Closed Articmar closed 3 months ago

Articmar commented 4 months ago

For several versions in a row now, the theme has been setting up sharp corners for LibreWolf.

screen

Current setup:

abdmoh123 commented 3 months ago

A temporary workaround is to edit firefox-gnome-theme/theme/pars/csd.css.

Change

/* Headerbar top border corners rounded */
:root[tabsintitlebar][sizemode="normal"]:not([gtktiledwindow="true"]) #nav-bar {
    border-radius: env(-moz-gtk-csd-titlebar-radius) env(-moz-gtk-csd-titlebar-radius) 0 0 !important;
}

to

/* Headerbar top border corners rounded */
:root[tabsintitlebar][sizemode="normal"]:not([gtktiledwindow="true"]) #nav-bar {
    border-radius: 8px 8px 0 0 !important;
}
rafaelmardojai commented 3 months ago

Hmm, if -moz-gtk-csd-titlebar-radius not existing in LibreWolf is the problem I guess it could be fixed in the theme with a env() fallback value:

:root[tabsintitlebar][sizemode="normal"]:not([gtktiledwindow="true"]) #nav-bar {
    border-radius: env(-moz-gtk-csd-titlebar-radius, 8px) env(-moz-gtk-csd-titlebar-radius, 8px) 0 0 !important;
}

Please test if that works.

abdmoh123 commented 3 months ago

I am using firefox so I don't think libreWolf is the problem.

abdmoh123 commented 3 months ago

Just tested it, your solution works too

rafaelmardojai commented 3 months ago

@abdmoh123 nice, I'm not sure what the requirement for -moz-gtk-csd-titlebar-radius to be set is then, but it works in my system (firefox flatpak, fedora 39).

Feel free to open a PR with those changes if you want, otherwise I will patch it in the weekend.