search

rafaelmardojai / firefox-gnome-theme

A GNOME👣 theme for Firefox🔥
The Unlicense
3.46k stars 158 forks source link

Added gnomeTheme.noThemedIcons #763

Closed jaydenlo08 closed 3 months ago

jaydenlo08 commented 6 months ago

Added a way to allow original icons from Firefox to be used

jaydenlo08 commented 6 months ago

Just updated the README.

Sorry if this PR looks a bit hacky - I initially didn't intend to make this public, just thought might be a good idea to contribute back.

I haven't really opened PRs before so please tell me if I'm doing anything wrong

ghost commented 6 months ago

Just updated the README.

Sorry if this PR looks a bit hacky - I initially didn't intend to make this public, just thought might be a good idea to contribute back.

I haven't really opened PRs before so please tell me if I'm doing anything wrong

Ahah it's exactly how I started maintaining the vertical tab at first it was 3 hack patched together with time I used myself the toolbox of firefox to make it properly xD

And I had also forgotten the readme (why I told you since I had the same error at my first here).

jaydenlo08 commented 4 months ago

Kinda left this hanging for months - fixed some small bug related to the CSD

rafaelmardojai commented 3 months ago

Sorry, could you do a clean rebase? Doing a review with so many commits on it is a bit confusing.

jaydenlo08 commented 3 months ago

Sorry for asking this seemingly stupid question, but how do I do so? I am relatively new to the git and contributing world... My branch looks like this now (taken from gitg - sorry if it looks like a nightmare) image

jaydenlo08 commented 3 months ago

Hi Rafael, I think I may have just done a "clean rebase" after lots of experimenting (and learning). Hopefully it's much more reading now

rafaelmardojai commented 3 months ago

Thanks a lot!