rafaelmardojai / firefox-gnome-theme

A GNOME👣 theme for Firefox🔥
The Unlicense
3.32k stars 153 forks source link

URLBar suggestions is broken with 126 #771

Closed zapSNH closed 2 months ago

zapSNH commented 3 months ago

Describe the bug The .urlbarView is covering the URLBar content. If I remove this line, then the problem goes away.

To Reproduce

  1. Have Firefox 126
  2. Click on the URLBar
  3. Error appears

Expected behavior The URLBar isn't covered by .urlbarView.

Screenshots screenshot

Setup information

Additional context Simply pushing .urlbarView down isn't enough since the text content of the URLBar doesn't show up.

zzzsyyy commented 2 months ago

It may be necessary to port this fix to the beta branch, as many people use the beta branch on firefox-beta

paulvt commented 2 months ago

I still have this issue with the v126 tag checked out on Firefox 126.0.

And it is the same whether the --urlbar-container-height is 0px, 34px (as it is now) or 200px.

thomasaull commented 2 months ago

@paulvt Maybe try to check out the master. This works for me on Firefox Developer Edition which currently is on v126

paulvt commented 2 months ago

I already did, but master is only one commit ahead of v126 and that is a README.md change (see 1efffca).