rafaelmardojai / firefox-gnome-theme

A GNOME👣 theme for Firefox🔥
The Unlicense
3.32k stars 153 forks source link

[Vertical tab - Extension] Visual bug, Inconsistency #781

Closed ataractic closed 1 month ago

ataractic commented 2 months ago

Describe the bug When using light theme on white-background websites, we can't see the edge of the vertical tab bar, which makes it really unaesthetically pleasing (see the screenshots).

To Reproduce

  1. Install firefox-gnome-theme using curl script
  2. Install Tab Center Reborn and copy its' firefox-gnome-theme styling from the repository
  3. Go on GitHub, or any light background website
  4. See the thing

Expected behavior A 1px-wide separator should be present on the vertical tab bar edge to maintain visual consistency

Screenshots Firefox New Tab GitHub example

Setup information

Additional context Tested with and without gnomeTheme.extensions.tabCenterReborn.alwaysOpen and gnomeTheme.extensions.tabCenterReborn.animationDisabled

BirdInFire commented 1 month ago

It's indeed an issue, I will check on this very soon :)

edit: I also will try the mod on light theme from here (since I dev on dark I never checked on light)

BirdInFire commented 1 month ago

@ataractic have made a PR to fix, in the meantime you can add this into : theme/extensions/tab-center-reborn.css and restart,

Note : I have copied the way the browser draw the line under the header bar, so I will not change the color or the size / transparency (because by coping this code it will change too if Mozilla (or this theme) decide to modify the color in the variable).

#sidebar-box{
        border-right: 0.01px solid var(--chrome-content-separator-color) !important;
}
ataractic commented 1 month ago

Thank you @BirdInFire