rafaelmardojai / firefox-gnome-theme

A GNOME👣 theme for Firefox🔥
The Unlicense
3.32k stars 153 forks source link

Part of the Firefox browser‘s functional buttons overlap #805

Closed Niko3C closed 3 weeks ago

Niko3C commented 3 weeks ago
Snipaste_2024-06-24_14-14-39

I am currently using Firefox on windows 11 with version 127.0.1(64-bit). Firefox on windows 11 with version:127.0.1(64-bit),the system zoom in/out buttons are overlapping with the extensions,more tools,and application menu three buttons. I tried to modify the css files by myself,but it didn't work.I see the effect picture from you have the close button,but no matter how i try,and the final result is not able to show the effect according to your demo.At present,my solution is to enable the title in the customize toolbar in order to use it normally.Is there any way to solve the problem in the next version? I hope you can see my bug feedback,and i am looking forward to your reply,thank you very much!

rafaelmardojai commented 3 weeks ago

The theme doesn't support Windows see #107, maybe we can reopen that issue.

Niko3C commented 3 weeks ago

You're right. If you have time, we can work together to solve this problem!!

rafaelmardojai commented 3 weeks ago

Sure, actually looking at your screenshot the theme seems to be working pretty good on Windows, the only problem is that for window controls positioning the theme uses some linux only media queries to determine how many buttons there are and if they are in the left or right. But for Windows we can just asume that we have three buttons on the right.

Can you test if this CSS code solves the problem?

@media (-moz-platform: windows) {
    :root {
        --gnome-navbar-csd-offset: 117px;
    }
}
Niko3C commented 2 weeks ago

Thank you very much for your reply by using the method you gave I have successfully solved the problem. Here are my screenshots for other windows users:

Snipaste_2024-06-27_20-10-03
rafaelmardojai commented 2 weeks ago

Since it's a trivial fix, I'm going to add it to the theme.

Niko3C commented 1 week ago

Thank you for your reply. I have already made the necessary changes to the Windows theme. If anyone else needs it, you can have them come to my repository to view the files I have uploaded

Snipaste_2024-07-08_15-03-33
Niko3C commented 6 days ago

This is the URL of my project: https://github.com/Niko3C/firefox-gnome-theme_win11