search

rafaelmardojai / firefox-gnome-theme

A GNOME👣 theme for Firefox🔥
The Unlicense
3.42k stars 157 forks source link

Firefox 71+ popups theming broken #91

Closed rafaelmardojai closed 4 years ago

weeman1337 commented 4 years ago

@rafaelmardojai is this issue the same for selects and the context menus? I'm unable to screenshot it because they close when taking the screenshot :/

rafaelmardojai commented 4 years ago

@weeman1337 I don't have theming issues with selects or the context menus. Try to take a screenshot with timer, that should work.

Slomo17 commented 4 years ago

Same Problem here with the popup of menus, no Problem with contex menu though. Attached screenshot of how it is supposed to look like, and how it looks like on my system. screenshot Screenshot from 2019-12-18 16-00-47

rafaelmardojai commented 4 years ago

Yeah, I haven't found a fix yet. That's the reason why is labeled as help wanted.

Slomo17 commented 4 years ago

Yeah, I haven't found a fix yet. That's the reason why is labeled as help wanted.

Unfortunately i am not a developer, so all i can do to help ist testing.

rafaelmardojai commented 4 years ago

Looks like, FF is using shadow DOM in popups, so no styles from userChrome.css will work in them. (https://developer.mozilla.org/en-US/docs/Web/Web_Components/Using_shadow_DOM)

rafaelmardojai commented 4 years ago

Please, test latest commits. Popups theming should be working as expected.

Next days i will finish fixing last popups related smalls issues.

Slomo17 commented 4 years ago

Looks great, thank you very much

rafaelmardojai commented 4 years ago

Fixed.