search

rafaelmardojai / forge-sparks

Get git forges notifications
MIT License
70 stars 9 forks source link

some github notifications have incorrect links #23

Closed SoMuchForSubtlety closed 9 months ago

SoMuchForSubtlety commented 9 months ago

When clicking on a notification from github (for example, from a PR with "reason": "review_requested"). The link leads to https://github.com/org/repo/pulls instead of https://github.com/org/repo/pull/123. I think this used to work in the past.

From my testing, this only seems to affect private repos.

I can share raw API data for notifications in private if that would help.

rafaelmardojai commented 9 months ago

Yeah, it is documented in the Github access token setup dialog of the app, if you work with private repos you need to grant the full repo scope, otherwise the app doesn't have permission to get the pull request details (html url, status, etc). The current link is a fallback when the details request fails.

SoMuchForSubtlety commented 9 months ago

Thanks for the quick response :)