search

rafaelmardojai / forge-sparks

Get git forges notifications
MIT License
70 stars 9 forks source link

TypeScript #31

Open JumpLink opened 6 months ago

JumpLink commented 6 months ago

I would love it for the developer experience if the project would use TypeScript, also I could test our TypeScript types in a real scenario. Hence the question, would this project accept a pull request that ports your project to TypeScript?

rafaelmardojai commented 6 months ago

Yes I would accept a PR.

I wanted to port to TypeScript some time ago, but it was a bit unclear which type definition generator to use. Also I remember that when implementing an interface you had to implement even the methods that are not needed, like items_changed in Gio.ListModel, not sure if this is still a thing. Another complication was that I didn't have time to figure out the best way to combine gjspack with TypeScript.

JumpLink commented 6 months ago

We are currently merging the two generators ts-for-gir and gi.ts :)

These are exactly the kind of problems we need feedback on to make the generator better 👍 I hope I find the time for a PR soon