search

rafaelmardojai / share-preview

Test social media cards locally
GNU General Public License v3.0
101 stars 16 forks source link

og:image previews fail for WebP images #33

Closed da2x closed 1 year ago

da2x commented 2 years ago

Facebook, Reddit (#12), and Twitter supports WebP images in og:image (and twitter:image), but the app shows an o-slash icon instead.

It’s probably correct to show the o-slash and a warning for Mastadon as support varies depending on the ImageMagic version installed on each server instance (upstream issue #14983).

rafaelmardojai commented 2 years ago

The fact of checking if the image format is supported by the service sounds like something we should do.

But I think this concrete issue is because the toolkit texture loader doesn't support WebP. I will see what can I do.

pauloxnet commented 2 years ago

I know this issue is closed but I have the same error for unsupported WebP images and I don't think it's correct to open a new one.

rafaelmardojai commented 2 years ago

I know this issue is closed but I have the same error for unsupported WebP images and I don't think it's correct to open a new one.

The issue is open. I have fixed it locally but haven't had time to push the fixes yet.

pauloxnet commented 2 years ago

I know this issue is closed but I have the same error for unsupported WebP images and I don't think it's correct to open a new one.

The issue is open. I have fixed it locally but haven't had time to push the fixes yet.

Thanks. If you need someone to help reviewing the PRs I'll be glad to do that. I'm a Python developer but I'm learning Rust since few weeks.

rafaelmardojai commented 1 year ago

The app now should try to convert any WebP to PNG before passing it to GTK.