search

rafaelmardojai / share-preview

Test social media cards locally
GNU General Public License v3.0
100 stars 16 forks source link

Crash on a GitHub page with PNG image #69

Closed pauloxnet closed 6 months ago

pauloxnet commented 7 months ago

I'm using SharePreview 0.4.0 installed with flatpak on Ubuntu 23.10

It works pretty well but fail with the URL: https://pescara.python.it/

The landing page is hosted as a static HTML file on GitHub page, and contains PNG image.

$ RUST_BACKTRACE=full flatpak run com.rafaelmardojai.SharePreview

(share-preview:2): Gtk-WARNING **: 08:07:20.689: GtkText - did not receive a focus-out event.
If you handle this event, you must return
GDK_EVENT_PROPAGATE so the default handler
gets the event as well
thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: http::Error(InvalidUri(InvalidFormat))', /run/build/share-preview/vendor/http-client/src/isahc.rs:58:42
stack backtrace:
   0:     0x556c85b40281 - <unknown>
   1:     0x556c85b6b9cf - <unknown>
   2:     0x556c85b3d107 - <unknown>
   3:     0x556c85b40095 - <unknown>
   4:     0x556c85b415c3 - <unknown>
   5:     0x556c85b41354 - <unknown>
   6:     0x556c85b41b49 - <unknown>
   7:     0x556c85b41a47 - <unknown>
   8:     0x556c85b406e6 - <unknown>
   9:     0x556c85b41792 - <unknown>
  10:     0x556c857ad983 - <unknown>
  11:     0x556c857ade23 - <unknown>
  12:     0x556c85867b79 - <unknown>
  13:     0x556c8584858c - <unknown>
  14:     0x556c8584937a - <unknown>
  15:     0x556c85855d25 - <unknown>
  16:     0x556c8584e665 - <unknown>
  17:     0x556c8584de36 - <unknown>
  18:     0x556c85839282 - <unknown>
  19:     0x556c8582f8c9 - <unknown>
  20:     0x556c85b1ce4a - <unknown>
  21:     0x556c85b1c368 - <unknown>
  22:     0x7effffa68d47 - <unknown>
  23:     0x7effffa6ae57 - <unknown>
  24:     0x7effffa6b513 - g_main_context_iteration
  25:     0x7effffc50b1d - g_application_run
  26:     0x556c857b8d46 - <unknown>
  27:     0x556c857d7a53 - <unknown>
  28:     0x556c857d8949 - <unknown>
  29:     0x556c85b38beb - <unknown>
  30:     0x556c857b9255 - <unknown>
  31:     0x7efffec3b08a - <unknown>
  32:     0x7efffec3b14b - __libc_start_main
  33:     0x556c857ae825 - <unknown>
  34:                0x0 - <unknown>
rafaelmardojai commented 6 months ago

The issue was triggered by the data URL of the website icon (data:image/svg+xml,...), added support for those in the app.