search

rafaelp / css_browser_selector

A very small javascript library that allows you to create browser specific CSS to be merged into your normal classes. No more hacks or mischievous code in your CSS code.
http://rafael.adm.br/css_browser_selector/
626 stars 168 forks source link

IE11 not working #22

Open brentgees opened 11 years ago

brentgees commented 11 years ago

I tested it for ie11 on windows 7. But I get a red window instead of a yellow window

verbatim commented 11 years ago

I apologize. I have no access to IE10 or IE11. Do you have the user agent string? I have seen these by doing some searches:

IE10: Mozilla/5.0 (compatible; MSIE 10.0; Windows NT 6.1; Trident/6.0)

IE11 Mozilla/5.0 (IE 11.0; Windows NT 6.3; Trident/7.0; .NET4.0E; .NET4.0C; rv:11.0) like Gecko

brentgees commented 11 years ago

No need to apologize, it's alreay great that you share it :+1: And I also did some searches and tryed it with user agent string, but that didn't work for me :/

verbatim commented 11 years ago

try: http://www.whatsmyuseragent.com/

or http://www.useragentstring.com/

SoftCreatR commented 11 years ago

https://github.com/WoltLab/WCF/blob/8ac2c327dd34b93db4a3041ba2ca506360fffb17/wcfsetup/install/files/lib/data/user/online/UserOnline.class.php#L169

Written in PHP, but the regular expression itself should also work in JS. It matches all IE versions, including IE11.

eviweb commented 11 years ago

Hi,

if someone have time to review this patch ;)

Thanks

verbatim commented 11 years ago

Yes, I will take a look. I myself have no access to IE10 or IE11. But I will take a look at this and integrate when I can. Thanks.

From: eviweb notifications@github.com To: rafaelp/css_browser_selector css_browser_selector@noreply.github.com Cc: verbatim seeknosy@yahoo.com Sent: Tuesday, November 26, 2013 7:50 AM Subject: Re: [css_browser_selector] IE11 not working (#22)

Hi, if someone have time to review this patch ;) Thanks — Reply to this email directly or view it on GitHub.

wayferer commented 11 years ago

FWIW I have just tested the above commit on my IE11 and it works for me.

devanshidns commented 10 years ago

Where is the updated code for ie 11? I also get the string as: Mozilla/5.0 (IE 11.0; Windows NT 6.3; Trident/7.0; .NET4.0E; .NET4.0C; rv:11.0) like Gecko

wayferer commented 10 years ago

@devanshidns https://github.com/eviweb/css_browser_selector/commit/0ab8629a1b5d0ee8ff13f842b4d6cdcd622e5065

hbmuller commented 10 years ago

IE 11 can be tested with: !(window.ActiveXObject) && "ActiveXObject" in window

http://stackoverflow.com/questions/21825157/internet-explorer-11-detection

TheJaredWilcurt commented 10 years ago

This should work for detecting IE6-11 and potentially beyond.