search

rafaelpadilla / review_object_detection_metrics

Object Detection Metrics. 14 object detection metrics: mean Average Precision (mAP), Average Recall (AR), Spatio-Temporal Tube Average Precision (STT-AP). This project supports different bounding box formats as in COCO, PASCAL, Imagenet, etc.
Other
1.09k stars 215 forks source link

confidence and class name on rectangle #38

Closed tincher closed 2 years ago

tincher commented 3 years ago

Implementation of #22

rafaelpadilla commented 3 years ago

Hi @tincher ,

Thank you for your contribution.

I have a comment on this feature:

If an image has a lot of detections, the labels may overlap one another. It would be good if the user has the option to show the labels or not.

So, please, insert in the visual interface a checkbox. If the user decides to have the confidence level on their images, he/she would check this option.

tincher commented 3 years ago

Hi @rafaelpadilla .

Thank you for the kind comment and the reasoning behind it. I added the checkbock for class & confidence.

tincher commented 3 years ago

Hi @rafaelpadilla

I wanted to check if there is still anything missing or if this can be merged. Have a nice day

rafaelpadilla commented 3 years ago

@tincher

Thank you for your contribution.

Please, see my comments on your PR:

1) There is missing a space between the class name and the confidence. (see figure below) image

2) I think it is better to use the format "class (confidence%)", where the confidence is in % with two decimal places Ex: "person (44.40%)". So, the label would be implemented something like f"{class} ({confidence:.2f}%)"

3) Instead of using the same checkbox for both class and confidence, please, use one checkbox for each option.

4) The option to include the confidence on the image should appear only when there is the option "draw detection". "show confidence" is useless when there are only ground-truth boxes.

5) The checkboxes need to be aligned with the bottom of scroll bar on the left, so the space highlighted in red in the image below is reduced

image

Please, consider modifying these points.

matt-sharp commented 3 years ago

@tincher This is a really useful feature. Is it ready to be merged yet?

tincher commented 3 years ago

Not yet, I am currently writing my thesis and therefore I am short on time. I will look to finish it 2 weeks!

github-actions[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.