search

rafaelrinaldi / hn-cli

:newspaper: CLI to browse Hacker News
MIT License
460 stars 19 forks source link

add sorting by latest entries #9

Closed erickbelfy closed 8 years ago

erickbelfy commented 8 years ago

This pull should solve #7 . Feel free to give as many feedbacks as possible, i would like to follow your code standards. Thanks!

rafaelrinaldi commented 8 years ago

@erickbelfy Can you please check the build? The CI is breaking. As soon as you do that I can start the code review.

erickbelfy commented 8 years ago

@rafaelrinaldi I forgot to run lint script sorry about that :smile:

rafaelrinaldi commented 8 years ago

@erickbelfy Looking good! As a last request before merging it, can you update the instructions so users can be aware of this feature and how to use it?

rafaelrinaldi commented 8 years ago

@erickbelfy Looking good! Thanks for your interest in making the project better, that's truly appreciated.

thanks bro

erickbelfy commented 8 years ago

Thank you @rafaelrinaldi for all of your tips! Always good to work with you.

You can count on me :smile:

tumblr_mabfosuyxv1rpez6jo1_400

rafaelrinaldi commented 8 years ago

@erickbelfy I swear to you I was about to send that exact same .gif!