search

rafaelrinaldi / whereami

:round_pushpin: Get your geolocation information using freegeoip.app
MIT License
166 stars 11 forks source link

Move from freegeoip.net to ipinfo.io #8

Closed Naereen closed 6 years ago

Naereen commented 6 years ago

Move from freegeoip.net to ipinfo.io. See #7

Naereen commented 6 years ago

Hi @rafaelrinaldi, do you want to merge or close this?

rafaelrinaldi commented 6 years ago

@Naereen I just spent some time going through the discussion. It seems like we have two options:

  1. Use ipinfo.io which seems to follow almost the same format as we already have
  2. Use freeegeoip.app which the user @freegeoipapp was kind enough to give us a heads up

If we go with the first option which is what your PR is proposing, I'd like for us to reach out to them first to see if we can simply just hit their endpoint without any type of credentials or anything like that. It seems like even for non commercial use we still are required to setup an account.

If we go with the last option, not only we would not have to care about this particular problem that we have in the first option but also seems like we're gonna get a few other benefits:

What are your thougths @Naereen?

rafaelrinaldi commented 6 years ago

For the record, I've already sent them an email asking about this. Will update this PR once they get back to me.

Just want to play it safe here and make sure things work well for everybody. Thank you for your patience on getting this merged in.

Naereen commented 6 years ago

Thanks for your fast reply @rafaelrinaldi. Option 2. seems indeed way better, so I would say close this and just keep with freegeoip.app!

rafaelrinaldi commented 6 years ago

@Naereen Sounds good! I will do my best to get this in this week.

rafaelrinaldi commented 6 years ago

For the record, I've received an email from the ipinfo.io staff:

Hi Rafael,

Thanks for reaching out to us. You don't have to sign up for our service to be able to use the service for up to 1,000 requests per day. While you can use the API freely for up to 1,000 requests per day without a token, we strongly advise that you sign up for the free plan and use the token that is provided. The token enables you to get more information and it tracks requests making it easier to see your data. Additionally, should you need assistance, it will be very easy for us to provide as there will be data we can examine.

I hope this helps! Please let me know if you have any other questions. Have a great day!

Naereen commented 6 years ago

Thanks for sharing their reply @rafaelrinaldi!

rafaelrinaldi commented 6 years ago

@Naereen Released on version v1.4.0 🎉