search

rafaelvcaetano / melonDS-android

Android port of melonDS
GNU General Public License v3.0
768 stars 47 forks source link

Add microphone toggle button #1214

Open ricnava00 opened 1 year ago

ricnava00 commented 1 year ago

This adds a new button to toggle the microphone input. The main use is to quickly toggle the software blow on and off for games that require it (but it also disables other sources, so if the mic is set to real input it will also get disabled, and if it's set to disabled it will stay always disabled) I had a quick look at the code while implementing this, so I don't know if it's the most effective way I don't think I'll work more on this since it does what I needed, but it could be modified from a toggle to be a normal button, which blows when it's pressed Also, I give up on git. I tried to push on the submodule and it may have made a mess. Let me know if I also need to create a pull request from the submodule, or just feel free to copy/paste the code (https://github.com/rafaelvcaetano/melonDS-android-lib/commit/1175c71c57364bf4f80d98117611587bc0362ffc)

christopher3242 commented 10 months ago

Also no mic

Screenshot_2023-11-29-08-01-33-462_me.magnum.melonds.jpg

I have attached

ricnava00 commented 8 months ago

I merged the new updates and I created a pull request on the lib repo https://github.com/rafaelvcaetano/melonDS-android-lib/pull/5 I tried rebuilding everything and can confirm that the mic button appears for me and works as expected (from a fresh install, it is present in the default input layout; otherwise, it can be added normally)