search

rafaelvcaetano / melonDS-android

Android port of melonDS
GNU General Public License v3.0
764 stars 47 forks source link

Checking BIOS Directory not working correctly #996

Open hieuk opened 1 year ago

hieuk commented 1 year ago

Problem:
This is regarding the feature where the app automatically check if the custom BIOS directory provided is correct. If you leave the custom DS BIOS Directory empty/incorrect, and choose the default system as DSi, then the app will complain that the DSi BIOS directory does not contain the correct file even if it does.

Steps to reproduce (if applicable):

  1. Set custom DS BIOS Directory to an invalid folder, or leave it unset
  2. Set custom DSi BIOS Directory correctly
  3. Choose Default System as DSi

By the way, this check should probably happen when the directory is set up.

rafaelvcaetano commented 1 year ago

The feature is working as intended. But the feedback provided to the user might not be the best. The DSi system requires the BIOS files from the DS. I'll see if I can improve the way this feedback is conveyed to the user.

hieuk commented 1 year ago

The prompt shows the expectation for DSi directory even though it is the DS directory that has a problem though?

Lunardog15 commented 1 year ago

You need to have separate BIOS Directories for the DSI and DS files Works with the files from the emulator wiki that you can find here.

hieuk commented 1 year ago

I know how to make it work. I am reporting about the content of warning message :)