Open GooberRF opened 1 month ago
Personally I do not see usefulness especially for camera1
camera2
camera3
and heehoo
.
Personally I do not see usefulness especially for
camera1
camera2
camera3
andheehoo
.
heehoo
: both vivalahelvig
and bighugmug
have similar HUD messages, heehoo
is the odd one out and should be standardized.cameraX
: With the amount of times I've heard people (even relatively experienced players) make comments like "wait, how do I get back to first person?" after entering camera2
or camera3
, I have absolutely no reservations about adding help strings that do nothing but simply inform those who may be unaware.I do not like check_can_use_cheat_cmd
. It can print to console but it is supposed to be just a check. It also checks if the level is loaded which should not be part of its scope.
Further handle_camera_command
can be simplified. It does not need to take mode
. It can call call_target
and then check the camera mode.
cameraX: With the amount of times I've heard people (even relatively experienced players) make comments like "wait, how do I get back to first person?" after entering camera2 or camera3, I have absolutely no reservations about adding help strings that do nothing but simply inform those who may be unaware.
.
cmd exists.
It can print to console but it is supposed to be just a check.
Good point, fixed.
It also checks if the level is loaded which should not be part of its scope.
I disagree. It's a relevant factor and while the original game does not, it is vastly more intuitive to tell a player who enters a command why that command had no effect, rather than simply telling them nothing.
Further
handle_camera_command
can be simplified. It does not need to takemode
. It can callcall_target
and then check the camera mode.
Good point as well, I've refactored that code to address this.
.
cmd exists.
It does, and I'm a huge fan of it. It does not, however, serve even a somewhat similar purpose or address the same issue that this PR does.
This PR:
spectate
set the camera to free look (same ascamera2
) when issued in single player (as opposed to just kicking back an error)camera1
,camera2
,camera3
, andheehoo
builtin cheat commands. In the case ofheehoo
, this is displayed usinghud_msg
just likevivalahelvig
andbighugmug
. For thecameraX
commands, the help text is printed to the console so that when a player wants to go back to first person, they'll know how.Resolves #206