search

rafalh / dashfaction

A community patch for the Red Faction (2001) FPS game
https://www.factionfiles.com/ff.php?action=file&id=6252
Mozilla Public License 2.0
61 stars 11 forks source link

Add command to allow adding/changing/removing server password #289

Closed GooberRF closed 1 week ago

GooberRF commented 1 month ago

This PR adds the server_password command, which can be used either as server or via rcon to add a password to a server without one, change the existing password to something else, or remove the password entirely.

Syntax is server_password <password>

Resolves #125

is-this-c commented 1 month ago

I think sv_pass is better. It is simpler and was previously used by PF.

GooberRF commented 1 month ago

I think sv_pass is better. It is simpler and was previously used by PF.

I am personally of the view that adjusting the naming convention for all console commands to prioritize short length and sv_, cl_, r_, mp_, etc. prefixes (like id tech games) would be ideal, but unless rafalh were to decide to go that way, it's best to continue with the approach already established rather than having some commands follow the existing convention and some follow the id tech/PF approach.

sv_pass in my view would be a better way to name this command, but it doesn't match the established convention unlike server_password.

is-this-c commented 1 month ago

Don't those other games have tons of console naming inconsistencies anyway?

GooberRF commented 1 month ago

Don't those other games have tons of console naming inconsistencies anyway?

Not generally, but even if they did, I don't think Dash should. If a standard is established, it should be maintained unless there's a very good reason not to (or if the standard changes).

Again, I think using prefixes like this would be good, but it directly goes against the established standard, so I have no intention to use that approach unless the project owner wants to change the established standard.