search

rafalp / Misago

Misago is fully featured modern forum application that is fast, scalable and responsive.
http://misago-project.org
GNU General Public License v2.0
2.56k stars 530 forks source link

Don't allow too deep quotes #273

Open rafalp opened 10 years ago

discomethod commented 10 years ago

how deep is too deep?

rafalp commented 10 years ago

quote within quote will be max.

discomethod commented 10 years ago

what should the behavior be when this limit is exceeded? don't allow the user to quote, throw away the oldest quote, throw away the newest quote, other?

rafalp commented 10 years ago

You strip quotes that are nested within quote within quote. Then you should remove empty quotes and validate if message has content.

This will need changes in preparser and posting routines, which is why its assigned for 0.6 milestone, when posting routine will be rewritten from scratch and MD implementation will be cleaned up.

rafalp commented 10 years ago

For record, Misago parser now lives in misago.markup app. So far its just simple wrapper for markdown that extends it with basic BBCode support ([b][u][i] so far, but more are planned).

ghost commented 5 years ago

Dear @rafalp

If I understand correctly, some problems will be resolved with upgrade to markdown>3.

I just started that. Patterns need refactoring because breaking change with introduction of InlineProcessor. And references says that it should be faster (parse what Python's Re cannot).

See 'Flexible inline' change... https://github.com/Python-Markdown/markdown/commit/d18c3d0acab0e7469c3284c897afcb61f9dd1fea

...and Processor which I told you about: https://github.com/Python-Markdown/markdown/blob/master/markdown/inlinepatterns.py#L595

Best!

rafalp commented 1 year ago

This would be easy as pie to implement in Misago once AST-based parser is backported from v4 branch, in #1480