Closed sethaxen closed 1 year ago
All methods except print
now have tests. Perhaps you have suggestions on how to have a prettier print method? The default for AbstractUnitRange
would look like 1:1:10
, but it would be nice to 1) show as the range the underlying range object (e.g. Base.OneTo
) and 2) also show the dim, though it seems unnecessarily verbose to show the dim indices.
If you are showing it with keyword args we need a keyword constructor so it's runnable code
If you are showing it with keyword args we need a keyword constructor so it's runnable code
Good point. A keyword construct would be unnecessary, so I've removed keywords from the show method.
Merging #439 (5849f71) into main (d907a8e) will increase coverage by
0.05%
. The diff coverage is93.93%
.
@@ Coverage Diff @@
## main #439 +/- ##
==========================================
+ Coverage 89.26% 89.31% +0.05%
==========================================
Files 36 37 +1
Lines 2543 2574 +31
==========================================
+ Hits 2270 2299 +29
- Misses 273 275 +2
Impacted Files | Coverage Δ | |
---|---|---|
src/Dimensions/dimunitrange.jl | 89.47% <89.47%> (ø) |
|
src/Dimensions/dimension.jl | 88.33% <100.00%> (+0.09%) |
:arrow_up: |
src/array/array.jl | 95.16% <100.00%> (+0.47%) |
:arrow_up: |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
@rafaqz do you mind if I tag a patch release after merging this PR?
Go for it. I sent you a collaborator invite.
As suggested in #437, this PR adds a
DimUnitRange
type. Now all calls toaxes
return an object of this type. This allowssimilar
to take axes of a dimensional array and still produce a dimensional array type. It also allowsDimArray
s to be constructed from other array types.Here's an example:
There are still a handful of methods I need to write tests for.
Currently the test suite fails due to #438